Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held.
Chris Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71909 )
Change subject: soc/amd/mendocino: seprate STAPM and STT for DPTC
......................................................................
Patch Set 2:
(2 comments)
This change is ready for review.
File src/soc/amd/mendocino/dptc_acpi.c:
https://review.coreboot.org/c/coreboot/+/71909/comment/b8afecb6_52a7f78c
PS1, Line 14: struct dptc_stt_input default_input = DPTC_STT_INPUTS (
space prohibited between function name and open parenthesis '('
Please fix.
https://review.coreboot.org/c/coreboot/+/71909/comment/cf0e01c3_2f0eaf15
PS1, Line 132: struct dptc_stapm_input default_input = DPTC_STAPM_INPUTS (
space prohibited between function name and open parenthesis '('
Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71909
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia7999753dcbb5716a3b07ef22a096b55579b80b5
Gerrit-Change-Number: 71909
Gerrit-PatchSet: 2
Gerrit-Owner: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 13 Jan 2023 12:37:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment