Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38379 )
Change subject: drivers/spi/spi_flash: organize spi flash by sector topology
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38379/3/src/drivers/spi/spi_flash_i...
File src/drivers/spi/spi_flash_internal.h:
https://review.coreboot.org/c/coreboot/+/38379/3/src/drivers/spi/spi_flash_i...
PS3, Line 78: uint32_t id;
nit: Could consider splitting this into two uint16_t which would allow for tighter packing in an arr […]
Good call out. I'll swap that out when I get around to removing the name field.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38379
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9cc20ca0f3d0a1b97154b000c95ff2e7e87f3375
Gerrit-Change-Number: 38379
Gerrit-PatchSet: 3
Gerrit-Owner: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 16 Jan 2020 23:00:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment