Attention is currently required from: Jason Nien, Martin Roth.
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84206?usp=email )
Change subject: mb/google/carneena: Make sure bid isn't used uninitialized ......................................................................
mb/google/carneena: Make sure bid isn't used uninitialized
GCC LTO cought this.
Change-Id: Ie732b5be5cd9dc0abaf1a5efe023bcb0738dba1d Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/google/kahlee/variants/careena/variant.c 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/84206/1
diff --git a/src/mainboard/google/kahlee/variants/careena/variant.c b/src/mainboard/google/kahlee/variants/careena/variant.c index 33ad260..5a393e2 100644 --- a/src/mainboard/google/kahlee/variants/careena/variant.c +++ b/src/mainboard/google/kahlee/variants/careena/variant.c @@ -38,7 +38,8 @@ } }
- google_chromeec_get_board_version(&bid); + if (google_chromeec_get_board_version(&bid)) + return;
if (bid == 7) /*