Attention is currently required from: Felix Singer, Martin L Roth, Patrick Rudolph, Subrata Banik, Matt DeVillier, Stefan Reinauer, Kapil Porwal, Maximilian Brune, Angel Pons, Lean Sheng Tan.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74692 )
Change subject: Revert "util/ifdtool: Add option to create FMAP template"
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74692/comment/002ef4cd_8064c06f
PS2, Line 11: Above commit inserts multiple IFD regions not present into the default
: FMAP template, some of which overlap, resulting in far less space
: available for BIOS region / CBFS.
never mind. Can you try the following patch: […]
It's reading empty flash space:
FLREG10: 0xffffffff
etc.
The patch should work in this case, because the space is empty and all 1's.
But it doesn't solve the actual problem that ifdtool assumes 16 regions
for Skylake. Which seems to come from the v1/v2 idea (Intel never mentioned
any versioning, IIRC it was just made up years ago as a workaround).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74692
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7cbcbe16d508787f5c8aae4889199185890f0dc7
Gerrit-Change-Number: 74692
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Bill XIE
persmule@hardenedlinux.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Mon, 24 Apr 2023 18:00:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-MessageType: comment