30 Nov
2021
30 Nov
'21
2:42 p.m.
Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59753 )
Change subject: device/oprom: Add support for x86_64 mode ......................................................................
Patch Set 1:
(1 comment)
File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/c/coreboot/+/59753/comment/1c83789d_6d2801da PS1, Line 97: X86_EIP not sure if this is the right way to fix the compilation issue as X86_RIP doesn't exist but we still need to have .rip instead .eip for x86_64.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59753
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id0284bb92521de2a8acc55897ea4eb2a5c5b56c7
Gerrit-Change-Number: 59753
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik subi.banik@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Subrata Banik subrata.banik@intel.com
Gerrit-Attention: Subrata Banik subi.banik@gmail.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
Gerrit-Comment-Date: Tue, 30 Nov 2021 13:42:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment