[coreboot-gerrit] Change in coreboot[master]: ec/starlabs: Write the correct value for KLSE when suspending

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62608 )

Change subject: ec/starlabs: Write the correct value for KLSE when suspending
......................................................................

ec/starlabs: Write the correct value for KLSE when suspending

The current code will write the raw value from the CMOS, which doesn't
match the respective setting in EC.

Switch argument will write the correct value, and prevent the setting
being reset.

Signed-off-by: Sean Rhodes 
Change-Id: I93444cdb96eaf729630b48551d0853511b584634
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62608
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/ec/starlabs/merlin/acpi/suspend.asl
1 file changed, 15 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/ec/starlabs/merlin/acpi/suspend.asl b/src/ec/starlabs/merlin/acpi/suspend.asl
index 0f1c27c..c65ca6d 100644
--- a/src/ec/starlabs/merlin/acpi/suspend.asl
+++ b/src/ec/starlabs/merlin/acpi/suspend.asl
@@ -98,6 +98,20 @@
    }

_SB.PCI0.LPCB.EC.FLKE = _SB.PCI0.LPCB.FLKC
-	_SB.PCI0.LPCB.EC.KLSE = _SB.PCI0.LPCB.KLSC
+
+	Switch (ToInteger (_SB.PCI0.LPCB.KLSC))
+	{
+		// 0x00 == Disabled == 0x00
+		// 0x01 == Enabled  == 0xdd
+		Case (0x00)
+		{
+			_SB.PCI0.LPCB.EC.KLSE = 0x00
+		}
+		Case (0x01)
+		{
+			_SB.PCI0.LPCB.EC.KLSE = 0xdd
+		}
+	}
+
    _SB.PCI0.LPCB.EC.KLBE = _SB.PCI0.LPCB.KLBC
 }