Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44633 )
Change subject: mb/google/dedede/var/magolor: Add deivces settings
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44633/2/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/magolor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44633/2/src/mainboard/google/dedede...
PS2, Line 54: chip drivers/usb/acpi
: register "desc" = ""Integrated Bluetooth""
: register "type" = "UPC_TYPE_INTERNAL"
: register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H19)"
: device usb 2.7 on end
: end
This is already present in baseboard/devicetree.cb. Is this required here again?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44633
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc562b4a05c8955d2aec105f2f429f926ad1e702
Gerrit-Change-Number: 44633
Gerrit-PatchSet: 2
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 21 Aug 2020 03:15:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment