Attention is currently required from: Curtis Chen, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59952 )
Change subject: soc/intel/common: Not enable crashlog on all resets by default ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59952/comment/5d414f9f_482497fa PS1, Line 7: Not Do not …
Patchset:
PS1: This should be squashed in the parent commit.
File src/soc/intel/common/block/crashlog/crashlog.c:
https://review.coreboot.org/c/coreboot/+/59952/comment/f8bc011b_a14fceb0 PS1, Line 482: #if CONFIG(SOC_INTEL_CRASHLOG_ON_RESET) Please do that in C code and not the preprocessor. You could also log, that it’s disabled.