25 Oct
2019
25 Oct
'19
12:07 p.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36336 )
Change subject: Fix sarien depthcharge make build ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36336/1/payloads/external/Makefile.... File payloads/external/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36336/1/payloads/external/Makefile.... PS1, Line 32: $(CONFIG_MAINBOARD_DEPTHCHARGE) How about wrapping this in $(call strip_quotes,...)? That should also solve the issue without leaving BOARD empty if CONFIG_MAINBOARD_DEPTHCHARGE ends up, for some reason, being empty (without quotes), no?
--
To view, visit https://review.coreboot.org/c/coreboot/+/36336
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If61a1371ad8baf165b09ce045fc1a6c205c2c0ae
Gerrit-Change-Number: 36336
Gerrit-PatchSet: 1
Gerrit-Owner: Selma Bensaid selma.bensaid@intel.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 25 Oct 2019 19:07:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment