Attention is currently required from: Alicja Michalska, Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Tim Chu.
Shuo Liu has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/84301?usp=email )
Change subject: soc/intel/xeon_sp: Handle GPIO SMIs
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84301/comment/a93f6533_90fc1ecd?usp... :
PS2, Line 9: GPIO_SMI_STS
Why do you need to handle GPIO_SMIs? Why are they enabled when there are no mainboard_smi_gpi_handle […]
Not sure if there are other codes to enable an SMI handler (and configure specific GPIOs in SMI modes). The changes in this patch seems not presenting a full background.
File src/soc/intel/xeon_sp/smihandler.c:
https://review.coreboot.org/c/coreboot/+/84301/comment/b6f7f82c_058e231f?usp... :
PS2, Line 92: #if CONFIG(CPU_INTEL_SOCKET_LGA3647_1)
The reason to use a socket type config selector is?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84301?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I906978d2bb2c5e055143aab656e40e06c24ace8d
Gerrit-Change-Number: 84301
Gerrit-PatchSet: 2
Gerrit-Owner: Alicja Michalska
ahplka19@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Alicja Michalska
ahplka19@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 20 Sep 2024 01:02:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com