Attention is currently required from: Nico Huber.
Angel Pons has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/82762?usp=email )
Change subject: console/i2c_smbus: Allow to send data w/o register offset
......................................................................
Patch Set 1:
(1 comment)
File src/console/Kconfig:
https://review.coreboot.org/c/coreboot/+/82762/comment/268fa246_8b31b81b?usp... :
PS1, Line 322: bool "Write to a specific data register"
I wouldn't know why. It's generic console code, at least I think it is.
I suggested this because the option below mentions a logging device. In any case, I am resolving this because I don't care about it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82762?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1c714768fdd4aea4885e40a85d21fa42414ce32c
Gerrit-Change-Number: 82762
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 09 Jul 2024 14:38:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com