Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46442 )
Change subject: mb/google/kukui: change Jacuzzi followers LCMID to fixed value
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46442/13/src/mainboard/google/kukui...
File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/c/coreboot/+/46442/13/src/mainboard/google/kukui...
PS13, Line 15: /*
: * The boardid.c should provide board_id, sku_id, and ram_code.
: * board_id is provided by ec/google/chromeec/ec_boardid.c.
: * sku_id and ram_code are defined in this file.
: */
Put this right after license? […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46442
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b43b9153315ec65e9168c4e84ea844dff14d446
Gerrit-Change-Number: 46442
Gerrit-PatchSet: 14
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Chen-Tsung Hsieh
chentsung@chromium.org
Gerrit-CC: KU-TENG HSU
kuten@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 26 Oct 2020 13:10:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment