Attention is currently required from: Arthur Heymans, Eric Lai, Paul Menzel, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75756?usp=email )
Change subject: arch/x86: Introduce DUMP_SMBIOS_TYPE17 config
......................................................................
Patch Set 9:
(2 comments)
File src/arch/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/75756/comment/0899b64f_6773a25a :
PS5, Line 362: config DUMP_SMBIOS_TYPE17
: bool
: default n
: help
: Dump part of SMBIOS type17 dimm information
Acknowledged
do we need choice ?
can't we have something similar ?
```
config DUMP_SMBIOS_TYPE17
bool "Dump part of SMBIOS type17 dimm information."
default n
help
Dump part of SMBIOS type17 dimm information.
```
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/75756/comment/252884d5_18e99444 :
PS9, Line 265: 0x1A
do we have any existing macro for DDR4 (somewhere in the code)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75756?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b5ca1f4a59598531a6cba500672c2717f2a7b00
Gerrit-Change-Number: 75756
Gerrit-PatchSet: 9
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 13 Jun 2023 10:03:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment