Attention is currently required from: Matt DeVillier, Nico Huber, Paul Menzel.
Michał Żygowski has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/83469?usp=email )
Change subject: superio/ite,mb: Switch the mainboards' code to the new ITE GPIO driver
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
LGTM. […]
@matt.devillier@gmail.com do you possibly have any of the the boards modified by this patch and could test the LED blinks on suspend?
Commit Message:
https://review.coreboot.org/c/coreboot/+/83469/comment/be850cf4_c3cb253d?usp... :
PS2, Line 11:
Any hints for testers how to test this?
I guess people having the modified boards could build new ROMs and suspend them to S3 to check if the LEDs are blinking as before.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83469?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I707ee090ee2551b4935847e12ade678d36ff9302
Gerrit-Change-Number: 83469
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 17 Jul 2024 07:51:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org