Attention is currently required from: Nico Huber, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46907 )
Change subject: mb/intel/baskingridge: Replace invalid C-state values
......................................................................
Patch Set 15:
(1 comment)
Patchset:
PS15:
Did you ever test ACPI C-states (on linux) with haswell?
I wouldn't know how to test them. In any case, having all boards use the same ACPI C-state values will help w.r.t. maintenance and fixes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46907
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife34f7828f9ef19c8fccb3ac7b60146960112a81
Gerrit-Change-Number: 46907
Gerrit-PatchSet: 15
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 12 Jan 2021 16:51:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment