[coreboot-gerrit] [XS] Change in coreboot[main]: drivers/intel/fsp2_0: Add FSP-I and FSP-O

[Subrata Banik (Code Review)]

Attention is currently required from: Andrey Petrov, Christian Walter, Jérémy Compostella, Lean Sheng Tan, Patrick Rudolph, Paul Menzel, Ray Ni, Ronak Kanabar.

Subrata Banik has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/83113?usp=email )

Change subject: drivers/intel/fsp2_0: Add FSP-I and FSP-O
......................................................................

Patch Set 3:

(1 comment)

File src/drivers/intel/fsp2_0/include/fsp/info_header.h:

https://review.coreboot.org/c/coreboot/+/83113/comment/970f1e6a_a713cd8e?usp... :
PS3, Line 13: #define FSP_HDR_ATTRIB_FSPI		4
            : #define FSP_HDR_ATTRIB_FSPO		8
not sure if you wish to guard these macros against FSP 2.4 kconfig. Ideally adding new FSP APIs demands the major version change at FSP side but looks like Intel decided to used FSP 2.4 spec to include new APIs.