Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33155 )
Change subject: drivers/wifi: Add generic WiFi driver ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/33155/4/src/drivers/intel/wifi/chip.h File src/drivers/intel/wifi/chip.h:
https://review.coreboot.org/#/c/33155/4/src/drivers/intel/wifi/chip.h@19 PS4, Line 19: #include "drivers/wifi/generic_wifi.h"
Why?
+1. This should not be required.
https://review.coreboot.org/#/c/33155/4/src/drivers/wifi/generic.c File src/drivers/wifi/generic.c:
https://review.coreboot.org/#/c/33155/4/src/drivers/wifi/generic.c@195 PS4, Line 195: ) Was the check for !config->wake dropped intentionally?
https://review.coreboot.org/#/c/33155/4/src/drivers/wifi/generic.c@230 PS4, Line 230: const char *generic_wifi_acpi_name(const struct device *dev)
No we need unique names in case of multiple devices present?
That's an interesting thought. We haven't seen multiple devices for WiFi, but that doesn't mean it will remain the same in the future. Should this be addressed when there is a need for it?