Caesar Wang has posted comments on this change. ( https://review.coreboot.org/19558 )
Change subject: google/gru: support 800M/928M frequency for bob ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/19558/3/src/mainboard/google/gru/sdram_confi... File src/mainboard/google/gru/sdram_configs.c:
Line 49: if (IS_ENABLED(CONFIG_BOARD_GOOGLE_BOB) && board_id() < 4)
Rather than duplicating the file name list for all frequencies, why not jus
(1) Is that worth increasing the size to solve it? I'm assuming that's worth.
src/console/Makefile.inc to enable vsprintf.c in all stages, but I have seen some other build failure. ... CC bootblock/lib/memchr.o src/console/vsprintf.c:55:5: error: no previous prototype for 'snprintf' [-Werror=missing-prototypes] int snprintf(char *buf, size_t size, const char *fmt, ...)
Looks like, we don't need define the __PRE_RAM__ first. index 5b2486a..34aa370 100644 --- a/src/include/string.h +++ b/src/include/string.h @@ -15,9 +15,9 @@ void *memmove(void *dest, const void *src, size_t n); void *memset(void *s, int c, size_t n); int memcmp(const void *s1, const void *s2, size_t n); void *memchr(const void *s, int c, size_t n); +//#if !defined(__PRE_RAM__) int snprintf(char * buf, size_t size, const char *fmt, ...); +//#endif