Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61680 )
Change subject: soc/amd/common/block/pci/amd_pci_mmconf: add assert for MMCONF region ......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/pci/amd_pci_mmconf.c:
https://review.coreboot.org/c/coreboot/+/61680/comment/4b8c899f_332cd00b PS1, Line 15: CONFIG_ECAM_MMCONF_BASE_ADDRESS
I wonder if the number is getting truncated since it's missing the ULL suffix. […]
i set CONFIG_ECAM_MMCONF_BASE_ADDRESS to 1f8000000 and had to add a few & 0xffffffff t make things compile and got this output:
[DEBUG] 1f8000000
so it doesn't truncate, but this check is probably not needed, since compiling coreboot fails in both fsp_m_params.c and acpi/acpi.c due to wrong types. might still be a good idea to add some sort of comment that CONFIG_ECAM_MMCONF_BASE_ADDRESS is assumed to be below 4GB