7 Dec
2018
7 Dec
'18
6:16 p.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29967 )
Change subject: qclib: Add qclib support ......................................................................
Patch Set 2:
(1 comment)
lots of parts are commented out. please sort that out before the next iteration. Also, we indent code by tabs (as the build bot helpfully pointed out), so please account for that.
https://review.coreboot.org/#/c/29967/2/src/mainboard/google/mistral/mainboa... File src/mainboard/google/mistral/mainboard.c:
https://review.coreboot.org/#/c/29967/2/src/mainboard/google/mistral/mainboa... PS2, Line 21: #if 0 what's this for? if it's not needed, kick it out entirely.
--
To view, visit https://review.coreboot.org/c/coreboot/+/29967
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I534af71163d034ea04420dda6a94ce31b08c8a07
Gerrit-Change-Number: 29967
Gerrit-PatchSet: 2
Gerrit-Owner: nsekar@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: nsekar@codeaurora.org
Gerrit-Comment-Date: Fri, 07 Dec 2018 18:16:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment