Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56726 )
Change subject: soc/intel: Add new Kconfig INTEL_ALLOW_SOC_DEBUG_HOOKS ......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56726/comment/1d9f6480_7cb1175d PS4, Line 9: The intent of this Kconfig is, when selected, to compile in any : Intel-specific hooks that may be available.
Also, do we want this to be Intel-specific config or should this be a common config in src/Kconfig that can be used as required by each SoC?
Well, I asked Tim to move it into soc/intel (see above). It seems to be a very Intel-specific mechanism so I think that's appropriate? I still don't really know what exactly "debug hooks" refers to or how this "crashlog" works but it seems to be a completely vendor-specific mechanism?
At least for any of the SoCs I've been working on I wouldn't know what "enabling debug hooks" could mean, so that leads me to think this doesn't belong in src/Kconfig.