17 Jun
2020
17 Jun
'20
2:52 p.m.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42459 )
Change subject: [RFC] device: Add method for configuring bus master based on config option ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42459/1/src/device/Kconfig File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/42459/1/src/device/Kconfig@519 PS1, Line 519: config PCI_ALLOW_BUS_MASTER
Why this option? Why default to n?
Since we are able to boot without setting this bit, we would like to disable bus mastering by default. If anyone depends on this, you can re-enable it with this option, which would correspond to the current state.
--
To view, visit https://review.coreboot.org/c/coreboot/+/42459
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I876c48ea3fb4f9cf7b6a5c2dcaeda07ea36cbed3
Gerrit-Change-Number: 42459
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 17 Jun 2020 12:52:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment