wang qii has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43960 )
Change subject: soc/mediatek/mt8192: Add spi driver ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43960/1/src/soc/mediatek/mt8192/inc... File src/soc/mediatek/mt8192/include/soc/spi.h:
https://review.coreboot.org/c/coreboot/+/43960/1/src/soc/mediatek/mt8192/inc... PS1, Line 42:
Extra blank line.
Ack
https://review.coreboot.org/c/coreboot/+/43960/1/src/soc/mediatek/mt8192/spi... File src/soc/mediatek/mt8192/spi.c:
https://review.coreboot.org/c/coreboot/+/43960/1/src/soc/mediatek/mt8192/spi... PS1, Line 111: pad_select == SPI_PAD0_MASK
I think this will always fail. […]
Yes, "assert(pad_select == SPI_PAD0_MASK); ptr = pad0_funcs[bus];" looks good.