Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Tim Wawrzynczak, Meera Ravindranath, Angel Pons.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56899 )
Change subject: mb/intel/adlrvp: Rename spd_info struct based on memory topology
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56899/comment/1e5369ec_d873a0c9
PS1, Line 10: code.
nit: if you could add what all variables that you have renamed here ?
lp4_lp5_spd_info -> memory_down_spd_info
ddr4_ddr5_spd_info -> dimm_module_spd_info
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56899
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b7a66b5524d8b80776ab7578ce7b13181af7882
Gerrit-Change-Number: 56899
Gerrit-PatchSet: 1
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Comment-Date: Tue, 10 Aug 2021 15:43:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment