Attention is currently required from: Ashish Kumar Mishra, Karthik Ramasubramanian, Shelley Chen.
Subrata Banik has posted comments on this change by Ashish Kumar Mishra. ( https://review.coreboot.org/c/coreboot/+/83420?usp=email )
Change subject: vc/google/chromeos: Add configurable compression for logo file in cbfs ......................................................................
Patch Set 2: -Code-Review
(1 comment)
File src/vendorcode/google/chromeos/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/83420/comment/7fefd0ce_ee00cb64?usp... : PS2, Line 29: ifeq ($(CONFIG_BMP_LOGO_COMPRESS_LZMA),y) : cb_logo.bmp-compression := LZMA : else ifeq ($(CONFIG_BMP_LOGO_COMPRESS_LZ4),y) : cb_logo.bmp-compression := LZ4 : endif :
BMP_LOGO_COMPRESS_FLAG := none ifeq ($(CONFIG_BMP_LOGO_COMPRESS_LZMA),y) BMP_LOGO_COMPRESS_FLAG := LZMA else ifeq ($(CONFIG_BMP_LOGO_COMPRESS_LZ4),y) BMP_LOGO_COMPRESS_FLAG := LZ4 endif
That way you can use it in both cb_logo and cb_plus_logo i.e.
cb_logo.bmp-compression := $(BMP_LOGO_COMPRESS_FLAG) cb_plus_logo.bmp-compression := $(BMP_LOGO_COMPRESS_FLAG)
looking the below code and default behavior of "BMP Logo compression" choice, I felt we can rewrite this code as below?
``` config HAVE_BMP_LOGO_COMPRESS_LZMA bool depends on BMP_LOGO default y
choice prompt "BMP Logo compression" depends on BMP_LOGO default BMP_LOGO_COMPRESS_LZMA if HAVE_BMP_LOGO_COMPRESS_LZMA default BMP_LOGO_COMPRESS_LZ4 ... ```
WDYT?
``` BMP_LOGO_COMPRESS_FLAG := LZMA ifeq ($(CONFIG_BMP_LOGO_COMPRESS_LZ4),y) BMP_LOGO_COMPRESS_FLAG := LZ4 endif
cb_logo.bmp-compression := $(BMP_LOGO_COMPRESS_FLAG) cb_plus_logo.bmp-compression := $(BMP_LOGO_COMPRESS_FLAG) ```