Attention is currently required from: Felix Held.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71770 )
Change subject: mb/amd/(birman|mayan): Update chromeos.fmd files ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2:
talked with Fred aobut this and keeping the size in the fmap 120k in this patch and possibly changin […]
Is there any reason we have the assert set as == instead of <=? As long as there's enough space, it seems like we should be okay. What am I missing?
File src/mainboard/amd/birman/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/71770/comment/ef23bf84_599c0c85 PS2, Line 32: 128K
120k, not 128k
Will move the update to a follow-on patch.
File src/mainboard/amd/mayan/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/71770/comment/ca1320ac_db9cfdcb PS2, Line 32: 128K
120k, not 128k
same.