Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32219 )
Change subject: mb/google/hatch: Support 16MiB fmap
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/32219/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32219/3//COMMIT_MSG@9
PS3, Line 9: Add a config and
This is no longer true.
https://review.coreboot.org/#/c/32219/3/src/mainboard/google/hatch/Kconfig.n...
File src/mainboard/google/hatch/Kconfig.name:
https://review.coreboot.org/#/c/32219/3/src/mainboard/google/hatch/Kconfig.n...
PS3, Line 7: BOARD_ROMSIZE_KB_32768
nit: Can we put this and the other additions of BOARD_ROMSIZE_* here in alphabetical order?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32219
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc0103c7fd0d99439f40a31d23422401a6dce826
Gerrit-Change-Number: 32219
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 08 Apr 2019 20:11:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment