Attention is currently required from: Juan José García-Castro Crespo, Martin L Roth.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80722?usp=email )
Change subject: Documentation/tutorial/part1.md: Update Debian packages ......................................................................
Patch Set 1:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80722/comment/bdb6fdcf_61cd1b5c : PS1, Line 7: Update Debian packages : You could be more specific:
Install libssl-dev and pkg-config on Debian
https://review.coreboot.org/c/coreboot/+/80722/comment/f3f9fe81_1fc0997c : PS1, Line 10: Added We normally use present tense in commit messages: Add …
https://review.coreboot.org/c/coreboot/+/80722/comment/3d44db8b_406b07aa : PS1, Line 12: Also converted multiline package list to one-line code markup. As written, this should be a separate change-set/commit.
Patchset:
PS1: Welcome to coreboot! Thank you for your contribution. I added some nits. You can split out the unrelated change, and then commit that and amend the commit message with `git commit --amend -a` and then just run `git push`. As the Change-Id did not change, Gerrit is able to map the new commit to this change-set. If you have any questions, don’t hesitate to ask.
(Sorry, if you are already familiar to git and Gerrit, and my comment is too long.)
File Documentation/tutorial/part1.md:
https://review.coreboot.org/c/coreboot/+/80722/comment/e9f1f796_da359c8f : PS1, Line 39: `sudo dnf install git make gcc-gnat flex bison xz bzip2 gcc g++ : ncurses-devel wget zlib-devel patch` This seems unrelated to the change at hand. Please split this into a separate patch.