Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34412 )
Change subject: util/cbfstool/flashmap: Fix memory leaks on failed tests ......................................................................
util/cbfstool/flashmap: Fix memory leaks on failed tests
These don't matter much, but it keeps Coverity happy.
Change-Id: Ie750acb50ae1590c3aea533338a8827c03459c1a Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: Coverity CID 1302452, 1302453 --- M util/cbfstool/flashmap/fmap.c 1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/34412/1
diff --git a/util/cbfstool/flashmap/fmap.c b/util/cbfstool/flashmap/fmap.c index 06f179f..e6992c8 100644 --- a/util/cbfstool/flashmap/fmap.c +++ b/util/cbfstool/flashmap/fmap.c @@ -509,7 +509,8 @@
static int fmap_flags_to_string_test(void) { - char *str, *my_str; + char *str = NULL; + char *my_str = NULL; unsigned int i; uint16_t flags;
@@ -555,11 +556,11 @@ printf("FAILURE: bad result from fmap_flags_to_string\n"); goto fmap_flags_to_string_test_exit; } - free(my_str); - free(str);
status = pass; fmap_flags_to_string_test_exit: + free(str); + free(my_str); return status;
}