Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38003 )
Change subject: mainboard/google/puff: Enable net driver on pcie ep ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38003/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38003/3//COMMIT_MSG@7 PS3, Line 7: mainboard/google/puff: Enable net driver on pcie ep
AFAICT, the driver is already enabled for puff, so that part is a no=op for puff. […]
A few points here so I will enumerate them:
Point i) && iii) are essentially the same point about the kconfig part. This has been explicitly mentioned at the commit message about the rational behind this. This follows on from advice and agreement from previous patches talking with Furquan that we should practically leave the linker to do it's job and not make huge combinatoric messes in kconfigs when it pays no dividends. See discussion on https://review.coreboot.org/c/coreboot/+/37909
Fur point ii) I don't understand your criticism as that is precisely what the commit short line says as well as the very first and second paragraph of the commit msg body says. If the short msg is somehow unclear, please elaborate with an alternative.