Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31557 )
Change subject: rtc: Fix rtc_calc_weekday ......................................................................
Patch Set 10:
(4 comments)
https://review.coreboot.org/#/c/31557/9/src/lib/rtc.c File src/lib/rtc.c:
https://review.coreboot.org/#/c/31557/9/src/lib/rtc.c@31 PS9, Line 31: "Satur", "Sun", "Mon", "Tues", "Wednes", "Thurs", "Fri"
No, wait a second, you can't change this. It's a global convention that 0 is a Sunday. […]
Done
https://review.coreboot.org/#/c/31557/9/src/lib/rtc.c@99 PS9, Line 99:
Is this tab supposed to get added here?
Done
https://review.coreboot.org/#/c/31557/9/src/lib/rtc.c@120 PS9, Line 120:
No space after a cast, please.
Done
https://review.coreboot.org/#/c/31557/9/src/lib/rtc.c@134 PS9, Line 134: Current
nit: Not sure if adding this here makes sense... […]
Done