Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40488 )
Change subject: vc/amd/agesa/f.../Proc/Mem/Tech/DDR3: Support XMP memory profiles ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
If possible, I'd rather leverage the common SPD parsing code (used by native raminit on Intel northbridges)
https://review.coreboot.org/c/coreboot/+/40488/1/src/vendorcode/amd/agesa/Kc... File src/vendorcode/amd/agesa/Kconfig:
PS1: Please use SPDX
https://review.coreboot.org/c/coreboot/+/40488/1/src/vendorcode/amd/agesa/Kc... PS1, Line 15: if CPU_AMD_AGESA_FAMILY14 || CPU_AMD_AGESA_FAMILY15_TN || CPU_AMD_AGESA_FAMILY16_KB Unnecessary because this file is only included if CPU_AMD_AGESA_OPENSOURCE