HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59880 )
Change subject: IASL: Ignore IASL's "Missing dependency" warning ......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS9:
Sorry, I was slow. What's the point of this? Doesn't it only […]
New IASL release issues that warning. So we have those solutions: 1- Keep using old IASL version 2- Ignore unconditionally that warning for coreboot tree: meaning for existing code and also for any incoming new ASL code. 3- Ignore the warning only for existing code and display a message at the end of the build. 4- Fix the code for all those platforms.
#4 is not my choice because I don’t have all those platforms to test modifications. You also know even if we send a patch asking to test (meaning with “[TestMe]”), it will have maybe 0.1% chance to be tested by someone (see for example ASL_2 conversion). I think, the best solution is #3. We ignore the warning for existing code and at the end of the build, issue a message with the “infor-mation”, (see below for stumpy) asking to fix
Built samsung/stumpy (Stumpy) *** WARNING: The ASL code for this platform is incomplete. Please fix it. *** *** If _PRS is present, must have _CRS and _SRS *** *** If _SRS is present, must have _PRS, _CRS, and _SRS *** *** If _DIS is present, must have _SRS, _PRS, _CRS, and _SRS ***