Attention is currently required from: Hung-Te Lin, Roger Lu, Yu-Ping Wu, Yuchen Huang. Ran Bi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46878 )
Change subject: soc/mediatek/mt8192: add clkbuf and srclken_rc MT6359P driver ......................................................................
Patch Set 60:
(5 comments)
File src/soc/mediatek/mt8192/clkbuf.c:
https://review.coreboot.org/c/coreboot/+/46878/comment/f086fe1b_f7eef683 PS59, Line 15: #define PMIC_REG_MASK 0xFFFF : #define PMIC_REG_SHIFT 0
not used any more?
Done
https://review.coreboot.org/c/coreboot/+/46878/comment/b505d402_7fb33f0b PS59, Line 121: /
one blank line before this comment
Done
File src/soc/mediatek/mt8192/include/soc/clkbuf.h:
https://review.coreboot.org/c/coreboot/+/46878/comment/7a93bb76_5ad7853a PS59, Line 7: #define _BUF_BF_MASK(name) \ : (_BF_MASK(name, 0) >> name##_BITFIELD_SHIFT) : #define BUF_READ_FIELDS(addr, name) \ : (buf_read_field(addr, _BUF_BF_MASK(name), name##_BITFIELD_SHIFT)) : #define BUF_WRITE_FIELDS(addr, value, name) \ : (buf_write_field(addr, value, _BUF_BF_MASK(name), name##_BITFIELD_SHIFT)) :
- I think we'll only use these APIs in clkbuf. […]
Done
File src/soc/mediatek/mt8192/pmif.c:
https://review.coreboot.org/c/coreboot/+/46878/comment/06597d06_fd6e8792 PS59, Line 218: break
one blank line after break
Done
https://review.coreboot.org/c/coreboot/+/46878/comment/1748b632_f8dcca9e PS59, Line 248: break
one blank line after break
Done