HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43708 )
Change subject: src/soc/mediatek: Add include <types.h> ......................................................................
Patch Set 1:
(6 comments)
I've added comments to make the review easy. Thx
https://review.coreboot.org/c/coreboot/+/43708/1/src/soc/mediatek/common/ddp... File src/soc/mediatek/common/ddp.c:
https://review.coreboot.org/c/coreboot/+/43708/1/src/soc/mediatek/common/ddp... PS1, Line 53: BIT(0) needs <types.h>
https://review.coreboot.org/c/coreboot/+/43708/1/src/soc/mediatek/common/inc... File src/soc/mediatek/common/include/soc/spi_common.h:
https://review.coreboot.org/c/coreboot/+/43708/1/src/soc/mediatek/common/inc... PS1, Line 37: BIT(SPI_CMD_ACT_SHIFT) needs <types.h>
https://review.coreboot.org/c/coreboot/+/43708/1/src/soc/mediatek/mt8173/inc... File src/soc/mediatek/mt8173/include/soc/dsi.h:
https://review.coreboot.org/c/coreboot/+/43708/1/src/soc/mediatek/mt8173/inc... PS1, Line 56: BIT(0) needs <types.h>
https://review.coreboot.org/c/coreboot/+/43708/1/src/soc/mediatek/mt8183/ddp... File src/soc/mediatek/mt8183/ddp.c:
https://review.coreboot.org/c/coreboot/+/43708/1/src/soc/mediatek/mt8183/ddp... PS1, Line 26: BIT(0) needs <types.h>
https://review.coreboot.org/c/coreboot/+/43708/1/src/soc/mediatek/mt8183/dsi... File src/soc/mediatek/mt8183/dsi.c:
https://review.coreboot.org/c/coreboot/+/43708/1/src/soc/mediatek/mt8183/dsi... PS1, Line 36: BIT(11) needs <types.h>
https://review.coreboot.org/c/coreboot/+/43708/1/src/soc/mediatek/mt8183/inc... File src/soc/mediatek/mt8183/include/soc/dsi.h:
https://review.coreboot.org/c/coreboot/+/43708/1/src/soc/mediatek/mt8183/inc... PS1, Line 48: BIT(0) needs <types.h>