Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21774 )
Change subject: mb/dell: Add Dell Optiplex 790 ......................................................................
Patch Set 50:
(4 comments)
And I made mistakes
https://review.coreboot.org/#/c/21774/50/src/mainboard/dell/optiplex_790/gma... File src/mainboard/dell/optiplex_790/gma-mainboard.ads:
https://review.coreboot.org/#/c/21774/50/src/mainboard/dell/optiplex_790/gma... PS50, Line 23: : -- For a three-pipe setup, bandwidth is shared between the 2nd and : -- the 3rd pipe. Thus, probe ports that likely have a high-resolution : -- display attached first. The mainboard only has two video outputs (DP and VGA), this does not make any sense.
https://review.coreboot.org/#/c/21774/50/src/mainboard/dell/optiplex_790/gma... PS50, Line 63: Duplicate word
https://review.coreboot.org/#/c/21774/50/src/mainboard/dell/optiplex_790/mai... File src/mainboard/dell/optiplex_790/mainboard.c:
https://review.coreboot.org/#/c/21774/50/src/mainboard/dell/optiplex_790/mai... PS50, Line 14: Double empty line
https://review.coreboot.org/#/c/21774/50/src/mainboard/dell/optiplex_790/mai... PS50, Line 29: }; : : : : : FIXME: Only one of these is routed, thus only one DPx and one HDMIx entry should remain.