Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32044 )
Change subject: soc/intel/skylake: Update GFX devtree options ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/#/c/32044/5/src/soc/intel/skylake/chip.h File src/soc/intel/skylake/chip.h:
https://review.coreboot.org/#/c/32044/5/src/soc/intel/skylake/chip.h@314 PS5, Line 314: /* : * Selection of the primary display device : * 0: Display_iGFX : * 1: Display_PEG : * 2: Display_PCH_PCIe : * 3: Display_Auto (Default) : * 4: Display_Switchable : */ Please no comments that just repeat the code.
https://review.coreboot.org/#/c/32044/5/src/soc/intel/skylake/chip.h@323 PS5, Line 323: Display_iGFX, If this is 0, it's the default and can be left unset in the devicetrees.
https://review.coreboot.org/#/c/32044/5/src/soc/intel/skylake/romstage/romst... File src/soc/intel/skylake/romstage/romstage_fsp20.c:
https://review.coreboot.org/#/c/32044/5/src/soc/intel/skylake/romstage/romst... PS5, Line 264: if (CONFIG(ONBOARD_VGA_IS_PRIMARY)) Redundant configuration in Kconfig and the devicetree is discouraged. I'd prefer to hide the Kconfig for these platforms instead.