Attention is currently required from: Ravi kumar, Shelley Chen, mturney mturney, Julius Werner.
mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59195 )
Change subject: soc: Add dram information to cbmem
......................................................................
Patch Set 6:
(1 comment)
File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/59195/comment/340b9cef_751639d0
PS5, Line 174: mem_chip_info
Julius, […]
Since CB isn't passing data into QcLib, would it be better to pass NULL (address) and 0 (size) as the parameters to qclib_add_if_table_entry()? Would this be less confusing?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59195
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f1dd05ee224bf8284661c0afaa01d0a9d71daa7
Gerrit-Change-Number: 59195
Gerrit-PatchSet: 6
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: mturney mturney
quic_mturney@quicinc.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 29 Nov 2021 22:02:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: mturney mturney
quic_mturney@quicinc.com
Gerrit-MessageType: comment