Attention is currently required from: Eric Lai, Jon Murphy, Martin Roth.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75696?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/myst: Add pen detect support
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/google/myst/variants/myst/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75696/comment/3d1540f6_32fc2090 :
PS1, Line 77: device generic 0 on end
It's outside of the scope of this CL, but according to go/myst-skus we don't have a field to indicate whether a stylus is present or not, so we can't probe for it. Instead, we always enable it for all Myst boards.
Should we open a bug to add that, like we did for Frostflow?
- b/260473966
- https://review.coreboot.org/c/coreboot/+/70418
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75696?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I922d643a83c5cd8ea0ab9fe6733f7aa05d935802
Gerrit-Change-Number: 75696
Gerrit-PatchSet: 1
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Thu, 08 Jun 2023 15:35:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment