Attention is currently required from: Michał Żygowski, Arthur Heymans.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52781 )
Change subject: cpu/amd/agesa/family14/model_14_init.c: create correct MTRR solution
......................................................................
Patch Set 14:
(1 comment)
File src/cpu/amd/agesa/family14/model_14_init.c:
https://review.coreboot.org/c/coreboot/+/52781/comment/e2fe6541_5fcfea71
PS7, Line 24: if (acpi_is_wakeup_s3()) {
: restore_mtrr();
It looks like OemInitResume and OemS3LateRestore do not use the S3DataTypeMTRR part of the S3 NV dat […]
Boot tested and resume tested with `x86_setup_mtrrs_with_detect` only. Same MTRR solution is generated on coldboot and resume. Removed call to `restore_mtrr()` and left `x86_setup_mtrrs_with_detect()` only.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52781
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If706f8851ed0b1d45729e81175d82abb1d9193be
Gerrit-Change-Number: 52781
Gerrit-PatchSet: 14
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 12 Apr 2022 11:05:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Michał Kopeć
michal.kopec@3mdeb.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment