Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48694 )
Change subject: mb/prodrive/hermes: Update USB 2.0 settings ......................................................................
mb/prodrive/hermes: Update USB 2.0 settings
Test results show that USB signals look better with these settings.
Change-Id: Ib0dafab88d8dcc05388b724f6a7183c13ac64934 Signed-off-by: Angel Pons th3fanbus@gmail.com --- A src/mainboard/prodrive/hermes/devicetree.h M src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb 2 files changed, 30 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/48694/1
diff --git a/src/mainboard/prodrive/hermes/devicetree.h b/src/mainboard/prodrive/hermes/devicetree.h new file mode 100644 index 0000000..d4742b6 --- /dev/null +++ b/src/mainboard/prodrive/hermes/devicetree.h @@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef __MAINBOARD_DEVICETREE_DEF_H__ +#define __MAINBOARD_DEVICETREE_DEF_H__ + +#include <soc/usb.h> + +#define HERMES_USB2_CONFIG(pin) { \ + .enable = 1, \ + .ocpin = (pin), \ + .tx_bias = USB2_BIAS_0MV, \ + .tx_emp_enable = USB2_DE_EMP_ON_PRE_EMP_ON, \ + .pre_emp_bias = USB2_BIAS_28P15MV, \ + .pre_emp_bit = USB2_FULL_BIT_PRE_EMP, \ +} + +#endif /* !__MAINBOARD_DEVICETREE_DEF_H__ */ diff --git a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb index b543a78..9c66f65 100644 --- a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb +++ b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb @@ -91,37 +91,37 @@ # USB OC0: RP1 register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC0)" register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC0)" - register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC0)" - register "usb2_ports[1]" = "USB2_PORT_TYPE_C(OC0)" + register "usb2_ports[0]" = "HERMES_USB2_CONFIG(OC0)" + register "usb2_ports[1]" = "HERMES_USB2_CONFIG(OC0)"
# USB OC1: RP2 register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC1)" register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC1)" - register "usb2_ports[2]" = "USB2_PORT_TYPE_C(OC1)" - register "usb2_ports[3]" = "USB2_PORT_TYPE_C(OC1)" + register "usb2_ports[2]" = "HERMES_USB2_CONFIG(OC1)" + register "usb2_ports[3]" = "HERMES_USB2_CONFIG(OC1)"
# USB OC2: Internal Header CN_USB3_HDR register "usb3_ports[4]" = "USB3_PORT_DEFAULT(OC2)" register "usb3_ports[5]" = "USB3_PORT_DEFAULT(OC2)" - register "usb2_ports[4]" = "USB2_PORT_TYPE_C(OC2)" - register "usb2_ports[5]" = "USB2_PORT_TYPE_C(OC2)" + register "usb2_ports[4]" = "HERMES_USB2_CONFIG(OC2)" + register "usb2_ports[5]" = "HERMES_USB2_CONFIG(OC2)"
# USB 2.0 # USB OC3: Internal Header USB2_HDR1 - register "usb2_ports[6]" = "USB2_PORT_MID(OC3)" - register "usb2_ports[7]" = "USB2_PORT_MID(OC3)" + register "usb2_ports[6]" = "HERMES_USB2_CONFIG(OC3)" + register "usb2_ports[7]" = "HERMES_USB2_CONFIG(OC3)"
# USB OC4: Internal Header USB2_HDR2 - register "usb2_ports[8]" = "USB2_PORT_MID(OC4)" - register "usb2_ports[9]" = "USB2_PORT_MID(OC4)" + register "usb2_ports[8]" = "HERMES_USB2_CONFIG(OC4)" + register "usb2_ports[9]" = "HERMES_USB2_CONFIG(OC4)"
# USB OC5-7: not connected # BMC - register "usb2_ports[10]" = "USB2_PORT_MID(OC_SKIP)" + register "usb2_ports[10]" = "HERMES_USB2_CONFIG(OC_SKIP)" # piggy-back - register "usb2_ports[12]" = "USB2_PORT_MID(OC_SKIP)" + register "usb2_ports[12]" = "HERMES_USB2_CONFIG(OC_SKIP)" # M2 key E - register "usb2_ports[13]" = "USB2_PORT_MID(OC_SKIP)" + register "usb2_ports[13]" = "HERMES_USB2_CONFIG(OC_SKIP)"
# Thermal register "tcc_offset" = "1" # TCC of 99C