Attention is currently required from: Elyes Haouas, Paul Menzel.
Julius Werner has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84170?usp=email )
Change subject: commonlib/coreboot_tables.h: Increase GPIO_MAX_NAME_LENGTH to 17 for backlight enable
......................................................................
Patch Set 4: Code-Review-2
(1 comment)
Patchset:
PS4:
coreboot table entries are supposed to be stable once they start being used, and they need to be aligned.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84170?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6fca7f067dab07bda5a31c9b5796272bea9763e1
Gerrit-Change-Number: 84170
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 17 Sep 2024 23:26:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes