Attention is currently required from: Stefan Reinauer, Lean Sheng Tan, Alexander Couzens.
Abel Briggs has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64013 )
Change subject: [WIP] drivers/pc80: Rework to reduce code duplication ......................................................................
Patch Set 14:
(1 comment)
Patchset:
PS14:
What are the problems with SMM? What do you thing needs to be solved before merge?
Mainly, the "public APIs" added in this commit probably need to be separated into their own compilation unit, because they need to be compiled into SMM.
Currently, everything's implemented and exported in the same file, and that means we're compiling the PC80 keyboard init code into SMM as well. I don't think it functionally changes anything (assuming nobody calls keyboard init in SMM...), but it's definitely not correct.
As for the status of this patchset, I recently relocated long distance and won't be able to work on anything coreboot-related until at least the start of next year. If there's interest in merging sooner, I have no problem if someone takes over the patchset.