Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47311 )
Change subject: mb/google/zork: Power off fingerprint sensor on shutdown
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47311/3/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/47311/3/src/mainboard/google/zork/v...
PS3, Line 354: if (slp_typ == SLP_TYP_S5) {
Quick question: Is there external PD on the GPIO_11 signal? If yes, then you don't need this setting […]
No, there isn't a pulldown. There's actually a pull-up, but it's PP3300_FPMCU
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47311
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3837b58372d8f4a504535e76bd21c667d68f8995
Gerrit-Change-Number: 47311
Gerrit-PatchSet: 8
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Nov 2020 20:09:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment