Attention is currently required from: Arthur Heymans.
Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84042?usp=email )
Change subject: soc/intel/pmclib.c: Work around compiler bug -Werror=stringop-overread ......................................................................
Patch Set 11: Code-Review+2
(1 comment)
Patchset:
PS11: Seems to happen only for x86_64. I've looked at the compiled code (with -Wno-error=stringop-overread) to be sure, looks good to me: ``` 0000000004000791 <print_num_status_bits>: 4000791: 85 f6 test %esi,%esi 4000793: 74 68 je 40007fd <print_num_status_bits+0x6c> 4000795: 41 55 push %r13 4000797: 41 54 push %r12 4000799: 55 push %rbp 400079a: 53 push %rbx 400079b: 51 push %rcx 400079c: 89 f5 mov %esi,%ebp 400079e: 49 89 d4 mov %rdx,%r12 40007a1: ff cf dec %edi 40007a3: 48 63 df movslq %edi,%rbx 40007a6: 49 bd ff 19 02 04 00 movabs $0x40219ff,%r13 40007ad: 00 00 00 40007a8: R_X86_64_64 printk 40007b0: 89 d8 mov %ebx,%eax 40007b2: 85 db test %ebx,%ebx 40007b4: 78 3f js 40007f5 <print_num_status_bits+0x64> ``` `num_bits` should be in `%edi`, it's decremented, then checked...