Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48267 )
Change subject: sb/intel/common: Modify CONFIG_LOCK_MANAGEMENT_ENGINE behavior
......................................................................
Patch Set 5:
(1 comment)
File src/southbridge/intel/common/firmware/Kconfig:
https://review.coreboot.org/c/coreboot/+/48267/comment/1746df14_9612f02c
PS5, Line 60: default n
Good call Nico, probably depends on LOCK_MANAGEMENT_ENGINE, since it modifies the behavior of it... […]
@TIm, correct, LOCK_MANAGEMENT_ENGINE does more like touching other master's access permissions than it supposed to do. At least we should limit modifying other master access permissions (like ME/GBE/EC etc) when LOCK_MANAGEMENT_ENGINE is selected. For other master access permissions, IFDTool needs to be enhanced to support granular actions. Thoughts?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48267
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f6677ab7b59ddce827d3fcaae61508a30dc1b28
Gerrit-Change-Number: 48267
Gerrit-PatchSet: 5
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Mon, 25 Jan 2021 05:10:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment