Attention is currently required from: Nicholas Chin.
Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/82127?usp=email )
The change is no longer submittable: All-Comments-Resolved and Code-Review are unsatisfied now.
Change subject: mb/dell: Add Latitude E6520 (Sandy Bridge) ......................................................................
Patch Set 6: -Code-Review
(1 comment)
File src/mainboard/dell/snb_ivb_latitude/variants/e6520/early_init.c:
https://review.coreboot.org/c/coreboot/+/82127/comment/7c7d02ec_7226468f?usp... : PS6, Line 8: const struct southbridge_usb_port mainboard_usb_ports[] = { : { 1, 1, 0 }, : { 1, 1, 0 }, : { 1, 1, 1 }, : { 1, 1, 1 }, : { 1, 0, 2 }, : { 1, 1, 2 }, : { 1, 0, 3 }, : { 1, 0, 3 }, : { 1, 1, 5 }, : { 1, 1, 5 }, : { 1, 1, 7 }, : { 1, 1, 6 }, : { 1, 0, 6 }, : { 1, 0, 7 }, : }; this differs from the configuration in the devicetree. and this should be dropped anyway.