22 Jul
2020
22 Jul
'20
3:22 p.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43307 )
Change subject: soc/amd/common: Refactor and consolidate code for spi base ......................................................................
Patch Set 7:
Repeating comment from patchset #5. File soc/amd/common/block/lpc/lpc_util.c has more references to SPI_BASE_ADDRESS. Aaron restored CB:42523 which would block those x86-centric defines from appearing in psp-verstage builds.
--
To view, visit https://review.coreboot.org/c/coreboot/+/43307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50d9de269bcb88fbf510056a6216e22a050cae6b
Gerrit-Change-Number: 43307
Gerrit-PatchSet: 7
Gerrit-Owner: Martin Roth martinroth@google.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Eric Peers epeers@google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 22 Jul 2020 13:22:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment