Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43358 )
Change subject: cbgfx: Add blend functions to calculate transparency ......................................................................
Patch Set 3:
(8 comments)
https://review.coreboot.org/c/coreboot/+/43358/1/3rdparty/blobs File 3rdparty/blobs:
https://review.coreboot.org/c/coreboot/+/43358/1/3rdparty/blobs@1 PS1, Line 1: Subproject commit 7ad2d22452225a14c19b17570cb77920d8fc81a5
This looks like it doesn't belong here.
Yeah, saw this and corrected this in patch 2.
https://review.coreboot.org/c/coreboot/+/43358/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/43358/2/payloads/libpayload/drivers... PS2, Line 64: bvalue
nit: I'd maybe call this 'blend' (or 'blend_value' if you want) because 'bvalue' is a little unclear […]
Done
https://review.coreboot.org/c/coreboot/+/43358/2/payloads/libpayload/drivers... PS2, Line 84: int
can be void
Done
https://review.coreboot.org/c/coreboot/+/43358/2/payloads/libpayload/drivers... PS2, Line 182: UINT8_MAX
Sorry, this was wrong from me... […]
Done
https://review.coreboot.org/c/coreboot/+/43358/2/payloads/libpayload/include... File payloads/libpayload/include/cbgfx.h:
https://review.coreboot.org/c/coreboot/+/43358/2/payloads/libpayload/include... PS2, Line 225: 255
This would then be not really completely opaque, it would just be 255/256th opaque (which is fine be […]
Done
https://review.coreboot.org/c/coreboot/+/43358/2/payloads/libpayload/include... PS2, Line 241: * 255 = 100% opacity
Same here
Done
https://review.coreboot.org/c/coreboot/+/43358/1/payloads/libpayload/include... File payloads/libpayload/include/cbgfx.h:
https://review.coreboot.org/c/coreboot/+/43358/1/payloads/libpayload/include... PS1, Line 92: struct blend_value {
If this struct is internal for graphics.c it can be defined in there, doesn't need to be here. […]
moved to graphics.c
https://review.coreboot.org/c/coreboot/+/43358/1/payloads/libpayload/include... PS1, Line 244: #define OPACITY_60 153
Kinda odd to have this here (and no other percentage)? If anything, I would define this in depthchar […]
Done