Attention is currently required from: Martin Roth, Julius Werner, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49768 )
Change subject: sc7280: cpucp loading changes ......................................................................
Patch Set 16:
(42 comments)
File src/soc/qualcomm/sc7280/cpucp_load_reset.c:
https://review.coreboot.org/c/coreboot/+/49768/comment/5f798b8c_53a9b8bb PS16, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/32aca856_168fd898 PS16, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/31a83a70_a0d41bda PS16, Line 16: val |= 0x1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/d85cde99_31f0c7b7 PS16, Line 16: val |= 0x1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/85bd2aef_6504c88e PS16, Line 18: /* allow NS access to EPSS memory*/ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/16325455_de88a41a PS16, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/d7e18fe0_dc4b81a0 PS16, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/dbfdd369_9fbb5d1a PS16, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/6eb14510_8c66c507 PS16, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/3a43d772_d5c74fdc PS16, Line 22: val |= 0x1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/3611e332_30b668c9 PS16, Line 22: val |= 0x1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/a4fb5eed_67210ed0 PS16, Line 24: /* Enable subsystem clock. Required for CPUCP PDMEM access*/ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/aecc44a3_a6e049d6 PS16, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/de610b34_3681fe14 PS16, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/5dd2d866_cea19604 PS16, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/f7257f2a_a96dc423 PS16, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/40ad7278_cd6de7cf PS16, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/49768/comment/f68afbcc_15efc5a3 PS16, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/49768/comment/e49c87e5_1a06dc5e PS16, Line 32: bool cpucp_fw_entry; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/04cc3283_3d4559c7 PS16, Line 32: bool cpucp_fw_entry; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/2236f88d_4195177f PS16, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/fb41e498_c4000ff0 PS16, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/55290e9d_b43d0f52 PS16, Line 35: struct prog cpucp_fw_prog = code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/cdc44489_27c7551a PS16, Line 35: struct prog cpucp_fw_prog = please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/1ceb591f_4564674c PS16, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/0b7f20ec_7658e9f8 PS16, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/cfb24462_be74931f PS16, Line 38: cpucp_prepare(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/0deb6d4a_b1478530 PS16, Line 38: cpucp_prepare(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/2b845171_74c28892 PS16, Line 40: if (prog_locate(&cpucp_fw_prog)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/c7cb7877_b6916a17 PS16, Line 40: if (prog_locate(&cpucp_fw_prog)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/530ea477_017934df PS16, Line 41: die("SOC imagpe: CPUCP_FW not found"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/aea8e6f5_eabd084f PS16, Line 41: die("SOC imagpe: CPUCP_FW not found"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/0d238037_fbd8c162 PS16, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/b1c93412_bd6f77c4 PS16, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/7fd9546b_1abf0a1e PS16, Line 44: if (!cpucp_fw_entry) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/2d888df8_39b79228 PS16, Line 44: if (!cpucp_fw_entry) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/923e82f2_d18a945d PS16, Line 45: die("SOC image: CPUCP load failed"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/bfcd8da5_92abe74a PS16, Line 45: die("SOC image: CPUCP load failed"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/5ec44ac5_890e674e PS16, Line 49: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/a2d6e369_fb7fb6e0 PS16, Line 49: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
https://review.coreboot.org/c/coreboot/+/49768/comment/d7bc88dd_cf946f46 PS16, Line 20: REGION_SIZE(dram_cpucp) / KiB); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/eccf2a5a_5c2f6bf4 PS16, Line 20: REGION_SIZE(dram_cpucp) / KiB); please, no spaces at the start of a line